Skip to content

feat(cdk/portal): allow detached DOM nodes to be used in DomPortal #34024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gouvernathor wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −14
Open

feat(cdk/portal): allow detached DOM nodes to be used in DomPortal #34024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/cdk/portal/dom-portal-outlet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,24 +141,23 @@ export class DomPortalOutlet extends BasePortalOutlet {
*/
override attachDomPortal = (portal: DomPortal) => {
const element = portal.element;
if (!element.parentNode && (typeof ngDevMode === 'undefined' || ngDevMode)) {
throw Error('DOM portal content must be attached to a parent node.');
if (element.parentNode) {
// Anchor used to save the element's previous position so
// that we can restore it when the portal is detached.
const anchorNode = this.outletElement.ownerDocument.createComment('dom-portal');

element.parentNode!.insertBefore(anchorNode, element);

super.setDisposeFn(() => {
// We can't use `replaceWith` here because IE doesn't support it.
if (anchorNode.parentNode) {
anchorNode.parentNode.replaceChild(element, anchorNode);
}
});
}

// Anchor used to save the element's previous position so
// that we can restore it when the portal is detached.
const anchorNode = this.outletElement.ownerDocument.createComment('dom-portal');

element.parentNode!.insertBefore(anchorNode, element);
this.outletElement.appendChild(element);
this._attachedPortal = portal;

super.setDisposeFn(() => {
// We can't use `replaceWith` here because IE doesn't support it.
if (anchorNode.parentNode) {
anchorNode.parentNode.replaceChild(element, anchorNode);
}
});
};

/**
Expand Down
Loading