fix(ng-dev): prevent current working directory executable injection on Windows - #3905
Merged
alan-agius4 merged 1 commit intoAug 6, 2026
Merged
Conversation
…n Windows Sets NoDefaultCurrentDirectoryInExePath=1 during CLI initialization on Windows to ensure CreateProcess does not search the current working directory for bare executable names. Fixes angular#3897
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a platform check to set the NoDefaultCurrentDirectoryInExePath environment variable on Windows, preventing the search of the current directory for bare executables. The review feedback correctly points out that setting this variable inside the runParserWithCompletedFunctions callback occurs after ES module imports are resolved and evaluated, potentially leaving subprocesses spawned during module evaluation unprotected. It is recommended to move this configuration to the very top of the entry point file, before any imports.
clydin
approved these changes
Aug 6, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
NoDefaultCurrentDirectoryInExePath=1during CLI initialization on Windows to ensureCreateProcessdoes not include the current working directory in the search path when resolving bare executable names.Fixes #3897