build: update dependency firebase-admin to v14 - #3908
Merged
Conversation
angular-robot
Bot
added
the
area: build & ci
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades firebase-admin to version 14.2.0 and refactors the codebase to use modular subpath imports instead of the legacy namespace. Feedback recommends using Promise.allSettled instead of Promise.all in the scheduled unblock job to handle individual failures gracefully. Additionally, the reviewer suggests leveraging Firestore's type safety with doc.data() and adding a check to ensure the document exists before calling the GitHub API.
See associated pull request for more information. Closes angular#3775 as a pr takeover
alan-agius4
force-pushed
the
pr-takeover-3775
branch
from
August 7, 2026 12:56
149b564 to
28a59b9
Compare
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See associated pull request for more information.
Closes #3775 as a pr takeover