Briefings on the Free plan: once a week - #29
Merged
Merged
Conversation
Free gets one briefing (it has one newsletter), drafts only as on every plan, on a schedule of one day a week with one manual run a week. create_briefing and update_briefing refuse a longer schedule on Free and run_briefing refuses a second manual run within a week, saying when the next may be asked for. The engine also passes over a scheduled slot within 6 days of the last scheduled run, and drops a second manual run within a week, so a daily schedule kept after a downgrade runs weekly. Paid plans keep one briefing per newsletter up to their newsletter limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner decision D8: paid plans get one briefing per newsletter up to their newsletter limit (already enforced: one briefing a newsletter, and the plan's newsletter limit). Free gets one briefing, drafts only, weekly.
create_briefing/update_briefingon Free refuse a schedule of more than one day (validation_failed, pointing to change_plan).run_briefingon Free refuses a second manual run within 7 days (rate_limited, with the time the next may be asked for).Tests: new Free-plan tests in briefings-actions and briefings-engine; engine fixtures now make a paid account unless a test asks for Free. Full suite 3990 pass, 0 fail. Briefings Worker 0.41 MB (unchanged).
Deploy: app, API and the Briefings Worker. No migration.