Skip to content

Harden rate-limit keys, signup answers, owner pages and briefing prices - #37

Open
ankurmans wants to merge 5 commits into
mainfrom
security/hardening-b
Open

ankurmans wants to merge 5 commits into
mainfrom
security/hardening-b

Conversation

@ankurmans

Copy link
Copy Markdown
Owner

Four hardening changes, each with a regression test.

  • Rate limits key on the address Cloudflare sets (cf-connecting-ip) before the client's x-forwarded-for.
  • On a newsletter that confirms signups, every address gets the same answer; nothing extra is sent to an address that is already subscribed.
  • /api-keys, /approvals and /agent-activity show an owner-only notice to team seats.
  • Setting a briefing's own prices is send-class, like raising its budget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant