Repository navigation
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
There was a problem hiding this comment.
The change looks sound. I couldn't run a packaged app here (no macOS/Windows, and the Linux sandbox is missing Electron's system libraries). What I did check: the new config sets EnableCookieEncryption from off to on when applied to the lockfile's Electron 44.9.1 binary. In electron-builder 26.15.7 the fuse is set before signing, the macOS release script re-signs every Mach-O file, and the Windows --prepackaged installer step skips packing, so it doesn't change the signed app again. electron-builder.config.test.ts passes, and tsc -b reports no errors. I'd still like the CI check you describe (@electron/fuses read on the built artifacts) to confirm it.
Public API: unchanged. This is a packaging setting only; the one visible effect is the cookie storage format, which is one-way, as you note.
One small, non-blocking point: changing the fuse breaks the existing signature on the Electron framework binary. A local bun run pack on Apple Silicon (built with identity=null, without the release script re-signing it) will therefore produce an app that macOS won't launch until it is re-signed. Adding resetAdHocDarwinSignature: true next to the fuse would keep those local builds runnable, and release builds would be unaffected because they are re-signed anyway.
|
Folded into #63002, which now carries this change (the cookie-encryption fuse, plus the ad-hoc re-sign and the run-as-Node hardening) with the rest of the browser work. Closing in its favour. |
Packaged desktop builds store browser cookies in plain text. This turns on Electron's cookie encryption, so the browser pane's sign-ins are encrypted with the OS key store.
EnableCookieEncryptionfuseCookiesdatabasevaluein plain textencrypted_valueWhy now
@electron/fuses readshows the fuse off on Windows (dev 1259) and on macOS 2.2.5. A copy of a macOS cookie database hasvaluefilled andencrypted_valueempty.Notes for review
bunx @electron/fuses read --app <built app>reportsEnableCookieEncryption is Enabled. Not verified in a packaged build locally.RunAsNode, the Node options and inspect fuses, and the asar fuses each need their own change and test.Visual