Repository navigation
fix(app): stop reading plugin readiness from plugin.list - #64527
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
This fixes the dev typecheck break and the change is sound. On the base, tsc -b in packages/app fails at extensions.tsx:169 because ready no longer exists on PluginListOutput after #64524. With this PR it passes, and the update machine tests pass (7/7), including the stale-list case. Dropping the ready early return keeps the stale-list protection, because list.loaded still drops a finding only once a listed flag agrees with it.
Public API is unchanged: list.loaded is an event inside the app's update state machine, not a public event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devfails typecheck: #64525 readsreadyfromplugin.list, which #64524 removed. They merged a minute apart.The update machine doesn't need it. It already drops an update's finding only once a listed
outdatedflag agrees with it, so a list read before the server reloads its plugins (still showing the old flag) keeps the finding and the Update button stays hidden. I removedreadyfrom thelist.loadedevent and the early return.Verification
bun run typecheck:tscandbun typecheckinpackages/apppass (the failing CI step)bun run checkpasses