Skip to content

fix(app): stop reading plugin readiness from plugin.list - #64527

Merged
rekram1-node merged 1 commit into
devfrom
fix-plugin-ready
Nov 17, 2026
Merged

rekram1-node merged 1 commit into
devfrom
fix-plugin-ready

Conversation

@rekram1-node

Copy link
Copy Markdown
Collaborator

dev fails typecheck: #64525 reads ready from plugin.list, which #64524 removed. They merged a minute apart.

The update machine doesn't need it. It already drops an update's finding only once a listed outdated flag agrees with it, so a list read before the server reloads its plugins (still showing the old flag) keeps the finding and the Update button stays hidden. I removed ready from the list.loaded event and the early return.

Verification

  • bun run typecheck:tsc and bun typecheck in packages/app pass (the failing CI step)
  • the update machine tests pass, including the stale list case
  • bun run check passes

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the dev typecheck break and the change is sound. On the base, tsc -b in packages/app fails at extensions.tsx:169 because ready no longer exists on PluginListOutput after #64524. With this PR it passes, and the update machine tests pass (7/7), including the stale-list case. Dropping the ready early return keeps the stale-list protection, because list.loaded still drops a finding only once a listed flag agrees with it.

Public API is unchanged: list.loaded is an event inside the app's update state machine, not a public event.

@rekram1-node
rekram1-node merged commit ea79f69 into dev Nov 17, 2026
11 checks passed
@rekram1-node
rekram1-node deleted the fix-plugin-ready branch November 17, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant