Repository navigation
test(core): expect CLAUDE.md fallbacks in the Windows drive-letter test - #64530
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Looks right. The added ~/.claude/CLAUDE.md and <project>/CLAUDE.md entries follow the same order as the neighbouring "stops instruction candidates at the project root outside home" test, and the test still checks that nothing above the project root is watched. I removed the Windows-only skip and ran the file on Linux: the base fails this test and the PR passes it. typecheck:tsc passes for packages/core. I couldn't run it on Windows.
The public API is unchanged (test-only).
No concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows-only test
ConfigInstructionPlugin.Plugin > stops at the project root when the location drive letter differs in casehas failed on everydevrun ofunit (windows)since it landed (e.g. runs 44174426133 and 44183058287).It was added in #63929 at the same time #64474 turned CLAUDE.md fallback on by default and updated the other subscription expectations. Linux and macOS skip this test, so the two PRs never ran together before they merged. The test still checks what it's meant to: nothing above the project root is subscribed and the project
AGENTS.mdis loaded through the lowercase-drive path. Its expected watcher list just didn't include the~/.claude/CLAUDE.mdand<project>/CLAUDE.mdsubscriptions that discovery now always adds. The failing run's received list matches the new expectation exactly.Test-only change. I checked it locally by temporarily un-skipping the test on Linux, and
packages/coretypecheck passes.Requested by: @jlongster (James Long via Slack)