Skip to content

test(core): expect CLAUDE.md fallbacks in the Windows drive-letter test - #64530

Merged
jlongster merged 1 commit into
devfrom
fix/windows-drive-letter-claude-test
Nov 17, 2026
Merged

jlongster merged 1 commit into
devfrom
fix/windows-drive-letter-claude-test

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

The Windows-only test ConfigInstructionPlugin.Plugin > stops at the project root when the location drive letter differs in case has failed on every dev run of unit (windows) since it landed (e.g. runs 44174426133 and 44183058287).

It was added in #63929 at the same time #64474 turned CLAUDE.md fallback on by default and updated the other subscription expectations. Linux and macOS skip this test, so the two PRs never ran together before they merged. The test still checks what it's meant to: nothing above the project root is subscribed and the project AGENTS.md is loaded through the lowercase-drive path. Its expected watcher list just didn't include the ~/.claude/CLAUDE.md and <project>/CLAUDE.md subscriptions that discovery now always adds. The failing run's received list matches the new expectation exactly.

Test-only change. I checked it locally by temporarily un-skipping the test on Linux, and packages/core typecheck passes.

Requested by: @jlongster (James Long via Slack)

@opencodejr opencodejr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right. The added ~/.claude/CLAUDE.md and <project>/CLAUDE.md entries follow the same order as the neighbouring "stops instruction candidates at the project root outside home" test, and the test still checks that nothing above the project root is watched. I removed the Windows-only skip and ran the file on Linux: the base fails this test and the PR passes it. typecheck:tsc passes for packages/core. I couldn't run it on Windows.

The public API is unchanged (test-only).

No concerns.

@jlongster
jlongster merged commit b0cecfa into dev Nov 17, 2026
11 checks passed
@jlongster
jlongster deleted the fix/windows-drive-letter-claude-test branch November 17, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant