Skip to content

fix(core): skip the WAL checkpoint on database open - #64532

Draft
neriousy wants to merge 1 commit into
devfrom
skip-startup-checkpoint
Draft

neriousy wants to merge 1 commit into
devfrom
skip-startup-checkpoint

Conversation

@neriousy

Copy link
Copy Markdown
Member

Issue for this PR

N/A. Split out of #63729.

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Removes the PRAGMA wal_checkpoint(PASSIVE) that runs when the database opens.

A background service registers as soon as it listens and opens the database afterwards (packages/server/src/process.ts). The checkpoint runs synchronously on the event loop, so with a large WAL on a slow disk /api/info stops answering right after registration and clients count the booting service as unresponsive. #54810 has a 300 MB WAL on an HDD.

This moves the work rather than removing it: SQLite runs the same passive checkpoint after a commit once the WAL passes wal_autocheckpoint (1000 pages by default, which we don't change). Opening the database and checking migrations still run on the event loop, so boot on a stalled disk can still block health probes.

The checkpoint was added in #13633 to clean up stale WAL data after a kill mid-write and avoid SQLITE_MISUSE. SQLite recovers the WAL on open by itself and ignores frames from transactions that never committed, so I don't expect that to come back, but I haven't reproduced the original error. That's why this is a draft.

No feature flag: it removes one statement from database startup.

How did you verify your code works?

  • packages/core: bun typecheck, and database.test.ts, database-drizzle.test.ts, database-migration.test.ts, storage-failure.test.ts on Windows
  • Not measured: boot time with a large WAL on a slow disk

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

A background service registers as soon as it listens and opens the database afterwards, so a synchronous checkpoint of a large WAL on a slow disk keeps /api/info from answering right after registration. SQLite already runs the same passive checkpoint after a commit once the WAL passes wal_autocheckpoint.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant