fix: preserve markdown hyperlink targets#1058
Open
kitlangton wants to merge 22 commits into
Open
Conversation
…implify # ------------------------ >8 ------------------------ # Do not modify or remove the line above. # Everything below it will be ignored. # # Conflicts: # packages/core/src/renderables/__tests__/Markdown.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
label (destination)fallback while hyperlink support is unavailable or unknown.markup.link.labelandmarkup.link.urlstyling.Before
Clickable-capable terminals displayed redundant destinations:
After
When OSC 8 support is detected:
The displayed
OpenTUIlabel retains its label style and carries the hiddenhttps://github.com/sst/opentuiOSC 8 target.When OSC 8 support is unavailable or not yet detected, OpenTUI preserves the visible fallback:
Simplify And Safety Review
renderSelf()produces an empty transition frame.TextBuffer.clear()highlight-retention contract.SyntaxStyleinsertion rollback on allocation failure.Verification
bun test src/lib/detect-links.test.tspasses:12 pass, 0 fail.renderSelf()and produced an empty transition frame; commit0a9d460brestores the previously-safe event-driven refresh.