Repository navigation
Preserve compaction fields omitted from streamed deltas - #418
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
Both accumulator test classes pass on the compatibility and published Jackson versions, and core static checks pass. Could a maintainer approve the pending CI workflow? |
Contributor
|
Closing along with #417. The reasoning is in #417 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #417.
Update each compaction field only when the delta contains it. Check presence through the raw JsonField accessor and keep the existing typed accessor for replacement. Omitted fields retain their previous values; explicit null and empty strings continue to replace them.
Six regression tests cover partial updates in both directions, initially missing fields, explicit null/empty replacements, signature preservation, nonmutation and a complete streamed message converted back to request parameters. Five fail on unchanged main; the explicit-value control passes.
Validation
Both accumulator classes passed all 111 tests on the compatibility Jackson version and all 111 on the published Jackson version. Core Kotlin formatting,
detektMain,detektTest,lintKotlin, andgit diff --checkpassed.Tested on macOS arm64 with JDK 21. The full API/repository suite and Java 8 ecosystem tests were not run. No generated models, public signatures, dependencies or workflows changed. Compaction is beta-only, so no stable counterpart needs this change.