Repository navigation
Preserve additionalProperties in converted MCP tool schemas - #422
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
All 31 MCP module tests pass locally, along with module formatting and detekt checks. Could a maintainer approve the pending CI workflow? |
Contributor
|
Closing along with #421. The reasoning is in #421 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #421.
Copy an explicitly supplied MCP
JsonSchema.additionalPropertiesvalue into the Anthropic tool input schema. Preserve bothfalseandtrue; leave an omitted value absent. Existing properties, required fields and both definition forms remain unchanged.Validation
Four regression cases exercise public single-tool and list conversion APIs, serialized field presence and values, existing schema fields, definition retention and input nonmutation.
detektMain,detektTestandlintKotlinchecks passed.git diff --checkpassed.Tested on macOS arm64 with JDK 21 and pinned repository dependencies. The core SDK's complete suite, downstream ecosystem tests and live API validation were not run. No public signatures, dependencies or workflow changes.