Repository navigation
Retain structured-only MCP tool error details - #424
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
All 32 MCP module tests pass locally, together with the module formatting, Detekt and Kotlin lint checks. Could a maintainer approve the pending CI workflow? |
Contributor
|
Closing along with #423. The reasoning is in #423 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #423.
Serialize structured-only content once before selecting the success/error path. Errors now use that JSON in the existing
AnthropicException; successes retain their existing string content. Nonempty regular content retains precedence, and serialization failures use the existingAnthropicInvalidDataExceptionwith its cause.Validation
Tests invoke the public
BetaMcp.mcpTool(...).runnerwith actual MCP result objects. Coverage includes structured-only success/failure, empty and nested objects, false/zero/null values, ordinary error-text precedence, empty errors and serialization failures.git diff --checkpassed.No public method signatures or dependencies change. This follows the diagnostic-preservation intent of anthropics/anthropic-sdk-csharp#287 and anthropics/anthropic-sdk-go#461 while retaining Java's exception-based tool-error contract.
Tested on macOS arm64 with JDK 21. The full SDK suite and live API/MCP services were not tested. Existing Gradle deprecation warnings remain.