Repository navigation
fix(auth): settle token refresh launch failures - #426
Closed
sylvesterkaczmarek wants to merge 1 commit into
Closed
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
Author
|
The auth and credential suites pass (87 tests), together with the changed-file Detekt checks and core Kotlin formatting check. Could a maintainer approve the pending CI workflow? |
This was referenced Oct 5, 2026
Contributor
|
Closing along with #425. The reasoning is in #425 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #425.
Catch provider exceptions raised before getAsync returns its future and route them through completeAsync. This releases the in-flight slot, settles the same waiting futures and applies advisory backoff consistently with asynchronous failures.
Reuse the protected launch path for forced refreshes chained after earlier requests. The chained provider launch uses whenCompleteAsync with an explicit common-pool executor, following the repository callback rule rather than executing on the previous refresh's completing thread.
Validation
Five new tests cover foreground/mandatory launch failures, advisory stale-token delivery and backoff with an injected clock, joined forced-refresh callers, recovery and an exceptional-future control.
Tested on macOS arm64 with JDK 21.0.12.1. Live authentication, full API tests and Java 8 runtime execution were not run. No public signatures or dependencies changed. Launch failures now produce exceptionally completed futures instead of escaping synchronously and leaving later requests pending.