Conversation
gouveags
approved these changes
Sep 16, 2026
gouveags
left a comment
There was a problem hiding this comment.
This addresses the issue: callers can force SigV4 while retaining the default AWS credential chain, and the mode survives client copies. All 41 Mantle tests passed locally; additional local signing checks passed for sync and async clients, including copy() and with_options().
|
Thanks for working on this! The implementation looks great to me, and I left an approval after reviewing and testing it. @craigie-ant could you please take a look when you have a chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth_mode="auto" | "api_key" | "sigv4"toAnthropicBedrockMantleandAsyncAnthropicBedrockMantlecopy()/with_options()skip_auth/auth_modesettingsFixes #1893
Verification
uv run pytest tests/lib/test_bedrock_mantle.py -q— 41 passed./scripts/test— Python 3.10/Pydantic v2: 6026 passed; Python 3.10/Pydantic v1: 5813 passed; Python 3.14/Pydantic v2: 6026 passed; MCP v2: 39 passeduv run ruff check ...— passeduv run --all-extras pyright --project .— 0 errorsuv run mypy src/anthropic/lib/bedrock/_mantle.py tests/lib/test_bedrock_mantle.py— passed