ci: make clippy and rustfmt real CI gates (issue #22) - #64
Merged
Merged
Conversation
Member
Author
|
The CI workflow changes in CI changes needed (apply manually or with a
|
5 tasks
duyetbot
force-pushed
the
feat/cli-lint-gates
branch
3 times, most recently
from
September 14, 2026 16:22
07d7636 to
17fba63
Compare
Contributor
anyr size and startupStartup is wall time for a cold Size budget:
Budget check: ok raw timings[
{
"asset": "anyr-darwin-arm64",
"kind": "native",
"path": "/Users/runner/work/cli/cli/anyr-darwin-arm64",
"bytes": 2927768,
"size": "2.8 MiB",
"version": "0.1.11 (built 2026-09-14 16:55:29)",
"target": "aarch64-apple-darwin",
"os": "macos-latest",
"startup_version": {
"n": 21,
"min_ms": 2.8,
"median_ms": 3.0,
"p95_ms": 4.66,
"mean_ms": 3.29
},
"startup_help": {
"n": 21,
"min_ms": 2.44,
"median_ms": 2.7,
"p95_ms": 3.42,
"mean_ms": 2.79
}
},
{
"asset": "anyr-darwin-x86_64",
"kind": "native",
"path": "/Users/runner/work/cli/cli/anyr-darwin-x86_64",
"bytes": 3133696,
"size": "3.0 MiB",
"version": "0.1.11 (built 2026-09-14 16:55:35)",
"target": "x86_64-apple-darwin",
"os": "macos-latest",
"startup_version": {
"n": 21,
"min_ms": 27.81,
"median_ms": 31.81,
"p95_ms": 38.18,
"mean_ms": 32.13
},
"startup_help": {
"n": 21,
"min_ms": 30.76,
"median_ms": 34.61,
"p95_ms": 42.17,
"mean_ms": 35.06
}
},
{
"asset": "anyr-linux-arm64",
"kind": "native",
"path": "/home/runner/work/cli/cli/anyr-linux-arm64",
"bytes": 2888744,
"size": "2.8 MiB",
"version": "0.1.11 (built 2026-09-14 16:55:01)",
"target": "aarch64-unknown-linux-gnu",
"os": "ubuntu-24.04-arm",
"startup_version": {
"n": 21,
"min_ms": 0.68,
"median_ms": 0.72,
"p95_ms": 0.84,
"mean_ms": 0.74
},
"startup_help": {
"n": 21,
"min_ms": 0.74,
"median_ms": 0.79,
"p95_ms": 0.88,
"mean_ms": 0.8
}
},
{
"asset": "anyr-linux-x86_64",
"kind": "native",
"path": "/home/runner/work/cli/cli/anyr-linux-x86_64",
"bytes": 3231088,
"size": "3.1 MiB",
"version": "0.1.11 (built 2026-09-14 16:55:18)",
"target": "x86_64-unknown-linux-gnu",
"os": "ubuntu-latest",
"startup_version": {
"n": 21,
"min_ms": 1.0,
"median_ms": 1.02,
"p95_ms": 1.15,
"mean_ms": 1.04
},
"startup_help": {
"n": 21,
"min_ms": 0.97,
"median_ms": 1.0,
"p95_ms": 1.12,
"mean_ms": 1.01
}
},
{
"asset": "anyr-windows-x86_64.exe",
"kind": "native",
"path": "D:\\a\\cli\\cli\\anyr-windows-x86_64.exe",
"bytes": 2675712,
"size": "2.6 MiB",
"version": "0.1.11 (built 2026-09-14T16:56:34Z)",
"target": "x86_64-pc-windows-msvc",
"os": "windows-latest",
"startup_version": {
"n": 21,
"min_ms": 9.12,
"median_ms": 9.98,
"p95_ms": 10.81,
"mean_ms": 10.01
},
"startup_help": {
"n": 21,
"min_ms": 9.13,
"median_ms": 9.44,
"p95_ms": 9.81,
"mean_ms": 9.46
}
},
{
"asset": "anyr.wasm",
"kind": "wasm",
"path": "/home/runner/work/cli/cli/target/wasm-pkg/anyr_cli_bg.wasm",
"bytes": 181909,
"size": "177.6 KiB",
"version": "wasm",
"target": "wasm32-unknown-unknown",
"os": ""
}
] |
- help.rs: const thread_local initializer
- spawn.rs: derive Default; use !contains_key; struct shorthand in tests
- term.rs: div_ceil; writeln! instead of write with newline
- tui/view.rs: to_string() instead of format!
- upgrade.rs: unwrap_or_default()
- http.rs: rename to snake_case
- cmd/{config_tui,dispatch,keys,menu,models}.rs: &PathBuf -> &Path
- cmd/dispatch.rs: match -> matches!
Co-Authored-By: Claude Code <noreply@anthropic.com>
duyetbot
force-pushed
the
feat/cli-lint-gates
branch
from
September 14, 2026 16:53
17fba63 to
bc561d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
continue-on-error: truefromcargo fmt --checkcargo clippy --locked --all-targets -- -D warningsas a required CI stepclippyto rust-toolchain componentssrc/so the gates passPR status:
workflowscope; see comment)🤖 Generated with Claude Code