WIP: make additional decryption work - #306
Open
mlohvynenko wants to merge 1 commit into
Open
mlohvynenko wants to merge 1 commit into
mlohvynenko wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Resolve the unregistered diskencryption module dependency and correct crypto member destruction ordering.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Adds local encrypted-layer decryption support to the Service Manager and integrates it with image management.
Changes:
- Adds crypto helper, local key provider, and blob decryptor.
- Initializes decryption components and injects the decryptor into
ImageManager. - Updates the certificate-loader test stub.
| File | Description |
|---|---|
src/sm/app/aoscore.hpp |
Declares decryption dependencies and configuration. |
src/sm/app/aoscore.cpp |
Initializes decryption services and integrates them with image management. |
src/cm/smcontroller/tests/stubs/certloaderstub.hpp |
Implements the expanded certificate-loader interface. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // installed, so a node with no key provisioned starts up fine and only fails if it's asked to install | ||
| // an encrypted layer. | ||
|
|
||
| err = mLocalDataKeyProvider.Init(mAllocator, mIAMClient, mCertLoader, cLayerEncryptionCertType); |
| constexpr auto cSupportedMediaTypes = std::array { | ||
| oci::cMediaTypeLayerTar, | ||
| oci::cMediaTypeLayerTarGZip, | ||
| oci::cMediaTypeLayerTarGZipEncrypted, |
mlohvynenko
force-pushed
the
feature_decrypt_layer
branch
from
September 25, 2026 14:54
58397fa to
4963d69
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Encrypted gzip size handling is incomplete, and the required core-library API is unavailable at the configured revision.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
| constexpr auto cSupportedMediaTypes = std::array { | ||
| oci::cMediaTypeLayerTar, | ||
| oci::cMediaTypeLayerTarGZip, | ||
| oci::cMediaTypeLayerTarGZipEncrypted, |
Signed-off-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
mlohvynenko
force-pushed
the
feature_decrypt_layer
branch
from
September 25, 2026 15:46
4963d69 to
760f747
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical external API mismatches prevent compilation, and encrypted gzip handling and helper wiring remain incomplete.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (6)
|
|
||
| err = mImageManager.Init(mAllocator, mConfig.mImageManager, mSMClient, mImagesSpaceAllocator, mDownloader, | ||
| mFileInfoProvider, mOCISpec, mImageHandler, mDatabase); | ||
| mFileInfoProvider, mOCISpec, mImageHandler, mDatabase, mBlobDecryptor); |
| #include <core/common/monitoring/monitoring.hpp> | ||
| #include <core/common/spaceallocator/spaceallocator.hpp> | ||
| #include <core/common/tools/heapallocator.hpp> | ||
| #include <core/sm/imagemanager/blobdecryptor.hpp> |
Comment on lines
+51
to
+53
| err = mCryptoHelper.Init( | ||
| mAllocator, mIAMClient, mCryptoProvider, mCertLoader, "", mConfig.mIAMClientConfig.mCACert.c_str()); | ||
| AOS_ERROR_CHECK_AND_THROW(err, "can't initialize crypto helper"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.