Skip to content

Fix async connection issue in BaseDatabricksHook - #72014

Open
Paxx2303 wants to merge 1 commit into
apache:mainfrom
Paxx2303:fix-databricks-async-connection-issue-71525
Open

Fix async connection issue in BaseDatabricksHook#72014
Paxx2303 wants to merge 1 commit into
apache:mainfrom
Paxx2303:fix-databricks-async-connection-issue-71525

Conversation

@Paxx2303

Copy link
Copy Markdown

Fix RuntimeError when using async operators in triggerer environment.

Problem

When DatabricksExecutionTrigger or async operators use BaseDatabricksHook in the triggerer (where an event loop is running), it causes:

RuntimeError: You cannot use AsyncToSync to run a loop in the same thread as AsyncSync

Root Cause

Async methods in BaseDatabricksHook were using the synchronous databricks_conn property which calls BaseHook.get_connection(). When called from within a running event loop, this causes the RuntimeError.

Solution

  • Add aget_connection() async method wrapping BaseHook.aget_connection()
  • Add a_databricks_conn async property for async connection access
  • Add async helper methods: _a_get_connection_attr(), _a_endpoint_url(), _a_is_aws_federation(), _a_get_required_client_id()
  • Update all async methods to use the new async connection properties
  • Fix typo in proxies validation (invalid_ckeys -> invalid_keys)
  • Update _a_get_aad_token() to catch aiohttp.ClientResponseError instead of requests.HTTPError

Tests

Added comprehensive async tests including:

  • test_async_do_api_call_respects_schema
  • test_async_do_api_call_only_existing_response_properties_are_read

Generated-by: Claude Code (Opus 5)

Fix RuntimeError when using async operators in triggerer environment.

The issue was that async methods in BaseDatabricksHook were using the
synchronous databricks_conn property, which calls BaseHook.get_connection().
When these methods are called from within a running event loop (e.g., in
the triggerer process), this causes a RuntimeError because the sync
method cannot be called directly from async context.

Solution:
- Add async method aget_connection() that wraps BaseHook.aget_connection()
- Add async property a_databricks_conn for async access to the connection
- Add async helper methods: _a_get_connection_attr(), _a_endpoint_url(),
  _a_is_aws_federation(), _a_get_required_client_id()
- Update all async methods to use the async connection properties
- Fix typo in proxies validation (invalid_ckeys -> invalid_keys)
- Update _a_get_aad_token() to catch aiohttp.ClientResponseError
  instead of requests.HTTPError

Fixes apache#71525
@boring-cyborg

boring-cyborg Bot commented Aug 24, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant