Add Java SDK interface-design ADRs for mixed-lang and native Dags - #72019
Open
jason810496 wants to merge 2 commits into
Open
Add Java SDK interface-design ADRs for mixed-lang and native Dags#72019jason810496 wants to merge 2 commits into
jason810496 wants to merge 2 commits into
Conversation
jason810496
commented
Aug 24, 2026
Comment on lines
+90
to
+101
| ### 4. Interface based with `TaskArgs` getter | ||
|
|
||
| ```java | ||
| public static class Transform implements InputTask<TaskArgs> { | ||
| public void execute(@NotNull Context context, Client client, TaskArgs args) { | ||
| var extracted = args.require(0, Long.class); | ||
| var threshold = args.get(1, Double.class); // null when it resolves to nothing | ||
| log.log(INFO, "Got extracted value from the bound argument: {0}", extracted); | ||
| // ... | ||
| } | ||
| } | ||
| ``` |
Member
Author
There was a problem hiding this comment.
Remove TaskArgs.
Support context.arg_bindings instead of TaskArgs and provide example of pulling XCom via client with arg_bindings.
e.g.
arguments = []
for arg in context.arg_bindings:
if arg.type == XCom:
arguments.append(client.getXCom(arg.taskId));
else:
arguments.append(arg.value)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write the design for TaskFlow and native Dag for the Java-SDK up front, to settle the design early and surface as much context as possible for reviewers on the actual implementation PRs.
Was generative AI tooling used to co-author this PR?