Skip to content

Make cron timetables hashable #73859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 4 commits into from
Sep 29, 2026
Merged

Make cron timetables hashable #73859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
835e82e
Make cron timetables hashable
Pebble32 Sep 28, 2026
8f5abf5
Add newsfragment
Pebble32 Sep 28, 2026
5613682
Update airflow-core/tests/unit/timetables/test_trigger_timetable.py
Pebble32 Sep 29, 2026
22ff344
Remove newsfragment
Pebble32 Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow-core/src/airflow/timetables/_cron.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ def __eq__(self, other: object) -> bool:
return self._expression == other._expression and self._timezone == other._timezone

def __hash__(self):
return hash((self._expression, self._timezone))
return hash((self._expression, str(self._timezone)))

@property
def summary(self) -> str:
Expand Down
7 changes: 7 additions & 0 deletions airflow-core/tests/unit/timetables/test_trigger_timetable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,3 +1196,10 @@ def test_run_immediately_does_not_pick_future_run(get_info: typing.Callable[[],
assert info is not None
assert info.run_after <= pendulum.DateTime(2024, 11, 3, 5, 30, tzinfo=utc)
assert info.run_after == pendulum.DateTime(2024, 11, 2, 5, tzinfo=utc)


def test_cron_timetables_are_hashable():
timetable = CronTriggerTimetable("0 0 * * *", timezone="UTC")
same = CronTriggerTimetable("0 0 * * *", timezone="UTC")
assert timetable == same
assert hash(timetable) == hash(same)