fix: avoid skipping orphan file records - #1634
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1631.
CleanOrphanUploadFilescurrently requests page 2 after mutating the page-1 rows fromstatus=availabletostatus=deleted. Because the filtered result set shrinks, offset pagination can skip records.This change repeatedly reads the first page while cleanup changes the result set, and stops when a pass makes no progress. This preserves the existing behavior for recent or referenced files while ensuring later eligible records are examined.
Changes
Testing
go test ./internal/service/file_record ./internal/repo/file_record -count=1go vet ./internal/service/file_record ./internal/repo/file_recordgit diff --checkThe focused regression test fails on the pre-fix implementation because record 1,001 remains available, and passes with this change.
AI assistance
Codex was used for repository analysis, reproduction, implementation, and test development. The submitting contributor is responsible for reviewing and understanding the complete patch and its test results.