fix(ai-prompt-guard): pass through when no content is selected - #14006
Open
avnijainnn wants to merge 1 commit into
Open
avnijainnn wants to merge 1 commit into
avnijainnn wants to merge 1 commit into
Conversation
Author
|
@Santoshkumarpuppala Thanks again for the pointers! I’ve opened the focused fix with the TEST 9 upstream-response assertion and the embeddings array-input regression. The targeted Would appreciate your review when you get a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ai-prompt-guardcurrently returns HTTP 200 when no messages are selected for checking. Since returning a status code terminates plugin processing, the request does not continue to the upstream and clients receive an empty 200 response.This PR changes the empty-message path to use a bare
return, allowing the request to continue upstream as intended.It also adds regression coverage for:
match_all_rolesis falseinputThe targeted
ai-prompt-guardtest suite passes with 175 tests.Which issue(s) this PR fixes:
Fixes #13944
Checklist
Documentation update is not required because this change only corrects the existing pass-through behavior and does not introduce any new configuration or user-facing API.