Repository navigation
ci: prevent skipped push checks from bypassing merge queue - #11894
Merged
Merged
Conversation
Member
Author
Contributor
As in Datafusion PRs bypass the queue? I have seen several PRs that got rejected by tests in the queue, so I am not sure about this |
Contributor
|
Thank you @sdf-jkl |
Member
Author
|
As in DataFusion added an exception for gh-readonly-queue/** Datafusion is fine 🫡 |
Contributor
|
thanks for this ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix premature merge-queue merges introduced by #11788.
The broadened
pushtrigger also matches GitHub-managedgh-readonly-queue/**branches. A queue commit therefore triggers bothpushandmerge_groupruns of theCIworkflow. The upstream queue-branchpushrun skipsRequired Checks, potentially satisfying the required status prematurely while the fullmerge_grouprun is still pending.It's actually in DataFusion too, but I missed it 🤦
Fix
gh-readonly-queue/**from push-triggered CI while keeping fork branch pushes enabled.merge_groupCI unchanged.Evidence
Validation
Static workflow config/assertion updated. The behavior still needs validation with an actual merge-queue PR. Keep this as draft until verified.