Skip to content

[Parquet][C++] Cleanup and reorganization for Parquet encryption code #45525

Open

Description

@raulcd

Describe the enhancement requested

Based on the comment here:
#44990 (comment)

We could do some improvements to the Parquet encryption code. Quoting from the message:

I think at some point a large cleanup and reorganization phase would be deserved on the Parquet encryption code:

  • header and source file naming
  • object and method naming
  • reorganizing responsabilities across objects
  • wacky implementation details (e.g. why exactly do we need the mutable CryptoContext::start_decrypt_with_dictionary_page?)

Component(s)

C++, Parquet

Activity

  1. github-actions commented on May 17, 2026

    @github-actions

    This issue has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this issue will be closed in 14 days. If this improvement is still desired but has no current owner, please add the 'Status: needs champion' label.

  2. added
    Status: stale-warningIssues and PRs flagged as stale which are due to be closed if no indication otherwise
    on May 17, 2026
  3. raulcd commented on Jul 13, 2026

    @raulcd
    MemberAuthor

    I am going to re-open this issue, I think this is still desirable. cc @rok @pitrou

  4. reopened this on Jul 13, 2026
  5. removed
    Status: stale-warningIssues and PRs flagged as stale which are due to be closed if no indication otherwise
    on Jul 13, 2026
  6. imtherealnaska commented on Oct 13, 2026

    @imtherealnaska
    Contributor

    Hi @raulcd is this still a relevant issue ?

  7. raulcd commented on Oct 15, 2026

    @raulcd
    MemberAuthor

    I think so.

  8. imtherealnaska commented on Oct 15, 2026

    @imtherealnaska
    Contributor

    Can i pick it up ?

  9. adamreeve commented on Oct 15, 2026

    @adamreeve
    Contributor

    @imtherealnaska, I think this is still relevant but the requirements are quite vague, so I don't think it's a great issue to pick up for someone who isn't already familiar with this area of the code. Do you have thoughts on what improvements you'd like to make here?

  10. imtherealnaska commented on Oct 16, 2026

    @imtherealnaska
    Contributor

    I'm honestly new to the repo, so I thought I would take this as an opportunity to learn around this and contribute . If you have some pointers it would be great .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions