GH-50936: [C++][Integration] Replace RapidJSON with simdjson - #50937
Open
Reranko05 wants to merge 2 commits into
Open
GH-50936: [C++][Integration] Replace RapidJSON with simdjson#50937Reranko05 wants to merge 2 commits into
Reranko05 wants to merge 2 commits into
Conversation
Reranko05
force-pushed
the
gh-35460-integration2
branch
from
August 24, 2026 07:50
e50b949 to
72a256a
Compare
Collaborator
Author
|
@kou, Could you review this when you have time? |
kou
reviewed
Aug 24, 2026
github-actions
Bot
added
awaiting changes
pitrou
reviewed
Aug 24, 2026
| const auto& it = obj.FindMember(key); | ||
| RETURN_NOT_STRING(key, it, obj); | ||
| return it->value.GetString(); | ||
| Result<std::string> GetMemberString(const JsonObject& obj, std::string_view key) { |
Member
There was a problem hiding this comment.
Perhaps we can return Result<std::string_view> here?
Collaborator
Author
There was a problem hiding this comment.
I kept the helper returning std::string, as several callers require an owning string, but made the conversion from simdjson's std::string_view explicit.
| ARROW_ASSIGN_OR_RAISE( | ||
| auto timezone_string, | ||
| internal::ResolveSimdjsonResult(timezone.get_string(), "field was not a string")); | ||
| return timestamp(unit, std::string(timezone_string)); |
Member
There was a problem hiding this comment.
The explicit std::string cast isn't necessary, is it?
Collaborator
Author
There was a problem hiding this comment.
I checked this, but timestamp() currently takes a const std::string&, so the conversion is required here.
github-actions
Bot
added
awaiting change review
Reranko05
force-pushed
the
gh-35460-integration2
branch
from
August 24, 2026 09:57
70f43b3 to
e81a967
Compare
Reranko05
force-pushed
the
gh-35460-integration2
branch
from
August 24, 2026 10:00
e81a967 to
6c8592c
Compare
Reranko05
force-pushed
the
gh-35460-integration2
branch
from
August 24, 2026 10:58
6c8592c to
f4b4750
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR continues the simdjson migration by replacing the RapidJSON usage in the C++ JSON integration implementation with simdjson's DOM API and Arrow's existing
JsonWriter.Changes
simdjson::domtypes.JsonWriter.Fixes: #50936