GH-50957: [Python] Reject unexpected concat_tables keywords - #50959
Open
Sakshamm-Goyal wants to merge 1 commit into
Open
GH-50957: [Python] Reject unexpected concat_tables keywords#50959Sakshamm-Goyal wants to merge 1 commit into
Sakshamm-Goyal wants to merge 1 commit into
Conversation
uros-b
approved these changes
Aug 24, 2026
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
concat_tables()keeps**kwargsonly for the deprecatedpromoteargument, but previously discarded every other key. As a result, keyword typos and apparently meaningful inputs such asunify_schemaswere silently accepted without affecting the result.What changes are included in this PR?
TypeErrorbefore processing the deprecated compatibility argument.promoteis the only accepted extra argument.Are these changes tested?
python -m pytest -q python/pyarrow/tests/test_table.py -k 'concat_tables': 9 passed.python -m pytest -q python/pyarrow/tests/test_table.py: 181 passed, 33 skipped.git diff --checkpassed.Are there any user-facing changes?
Yes. Unknown
concat_tables()keyword arguments now raiseTypeError, matching normal Python call behavior. The deprecatedpromote=Trueandpromote=Falsecompatibility path remains unchanged.AI assistance
I used an AI coding assistant to help investigate the root cause, draft the focused two-file patch, and run validation. I reviewed and understand every change and can own and debug it during review.
Closes #50957