Skip to content

GH-51011: [C++][CI] Poll for GCS testbench readiness instead of one 10s attempt #51012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Sep 29, 2026
Merged

GH-51011: [C++][CI] Poll for GCS testbench readiness instead of one 10s attempt #51012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions cpp/src/arrow/filesystem/gcsfs_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,19 @@ class GcsTestbench : public ::testing::Environment {
}

server_process->SetArgs({"--port", port_});
server_process->IgnoreStderr();
// Keep stderr so that startup failures are visible in the test log.
status = server_process->Execute();
if (!status.ok()) {
error += ": " + status.ToString();
error_ = std::move(error);
return;
}

// The testbench may accept connections well before it answers requests,
// so poll with a per-attempt budget shorter than the overall one.
auto testbench_is_running = [&server_process, this]() {
auto ready_timeout = std::chrono::seconds(10);
auto ready_timeout = std::chrono::seconds(60);
auto attempt_timeout = std::chrono::seconds(5);
std::chrono::time_point<std::chrono::steady_clock> end =
std::chrono::steady_clock::now() + ready_timeout;
while (server_process->IsRunning() && std::chrono::steady_clock::now() < end) {
Expand All @@ -95,7 +98,7 @@ class GcsTestbench : public ::testing::Environment {
.set<gcs::RestEndpointOption>("http://127.0.0.1:" + port_)
.set<gc::UnifiedCredentialsOption>(gc::MakeInsecureCredentials())
.set<gcs::RetryPolicyOption>(
gcs::LimitedTimeRetryPolicy(ready_timeout).clone()));
gcs::LimitedTimeRetryPolicy(attempt_timeout).clone()));
auto metadata = client.GetBucketMetadata("nonexistent");
if (metadata.status().code() == google::cloud::StatusCode::kNotFound) {
return true;
Expand All @@ -105,7 +108,7 @@ class GcsTestbench : public ::testing::Environment {
};

if (!testbench_is_running()) {
error += " (failed to listen)";
error += " (did not become ready)";
error_ = std::move(error);
return;
}
Expand Down
Loading