Skip to content

GH-51487: [CI] Fix Emscripten wheel load failure by disabling llvm-strip on install #51488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 3 commits into from
Sep 30, 2026
Merged

GH-51487: [CI] Fix Emscripten wheel load failure by disabling llvm-strip on install #51488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f001b5c
Initial commit
tadeja Sep 24, 2026
0a82573
Update ci/scripts/python_build_emscripten.sh
tadeja Sep 30, 2026
d1a748f
Update code remaining code comment
tadeja Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci/scripts/python_build_emscripten.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,8 @@ if [ "${GITHUB_ACTIONS:-}" = "true" ]; then
fi

pushd "${python_build_dir}"
# scikit-build-core strips unnecessary symbols by default.
# LLVM 23 also removes the required dylink.0 section (llvm/llvm-project#180246)
export SKBUILD_INSTALL_STRIP=false

@raulcd raulcd Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering whether we want this happening on the rest of the wheels too.
Should we just try to add this section to the pyproject.toml:

[tool.scikit-build]
install.strip = false

We manually strip debug symbols on wheels when building but I am unsure we want to strip all as discussed in the past. Details here:

@rok what do you think?

@rok rok Sep 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding - what level of symbols do we want to distribute in wheels? Debug or less? Should we have debug wheels (that we perhaps only distribute through github and not pypi to save pypi quota).
How about distributing debug symbols separately? (see generated prototype here https://github.com/rok/arrow/pull/59/changes)

@raulcd raulcd Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this. This seems to have been the behaviour since scikit-build-core 0.5 and we've had several releases with it. No need to change current behavior globally.

pyodide build
popd
Loading