Repository navigation
Conversation
|
|
… KMS configuration
Collaborator
|
Thanks for the PR. I’m closing it because Arrow’s contributor guidelines require that AI-generated code be reviewed and understood by the person submitting it:
Once you’ve reviewed the changes and can own them yourself, you’re welcome to open a new PR. |
Author
|
Thanks for the clarification, will do! |
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
FileKeyWrapperapplies default KMS instance ID and URL values to its stored connection configuration, but passed the original configuration toGetKmsClient. KMS client factories could therefore receive empty values while the key material contained the defaults.What changes are included in this PR?
kms_connection_config_member toGetKmsClient.Are these changes tested?
parquet-encryption-key-management-testbinary passes: 24 tests.git diff --checkpass.Are there any user-facing changes?
KMS client factories receive the default instance ID and URL when callers leave those fields empty, matching the read-path behavior. There are no public API or breaking changes.
Closes #51351.
Was AI used for this PR?
AI was used to inspect the relevant code paths and CI failures, prepare the implementation and test changes, run local validation, and draft this description.
PR code and description written by:
Reviewed before submission by: