Repository navigation
GH-53500: Guard Parquet metadata equality against None - #53974
Closed
1932819331hy-debug wants to merge 4 commits into
Closed
1932819331hy-debug wants to merge 4 commits into
1932819331hy-debug wants to merge 4 commits into
Conversation
1932819331hy-debug
requested review from
AlenkaF,
raulcd and
rok
as code owners
October 16, 2026 11:27
Member
|
Fully automated PRs are not welcome, see https://arrow.apache.org/docs/developers/overview.html#ai-generated-code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Several Parquet metadata wrappers’ typed
equals()methods can dereferenceNone. Guard these arguments consistently withFileMetaData.equals()so explicit calls raiseTypeErrorand comparisons withNoneare safe.What changes are included in this PR?
NoneinStatistics,ColumnChunkMetaData,RowGroupMetaData,ParquetSchema, andColumnSchemaequals()methods.FileMetaData.Are these changes tested?
A regression test covers explicit
equals(None)calls and!= Nonecomparisons. Tests were not run locally; GitHub CI will validate the Cython build and test.Are there any user-facing changes?
Invalid
equals(None)calls now raiseTypeErrorinstead of risking a process crash. Equality comparisons withNoneremain safe.Was AI used for this PR?
PR code and description written by:
Reviewed before submission by:
Closes #53500