Repository navigation
GH-51368: [C++] Fix silent LF drop when quoted CRLF straddles CSV blo… - #54059
Open
AdityRajGupta wants to merge 1 commit into
Open
AdityRajGupta wants to merge 1 commit into
AdityRajGupta wants to merge 1 commit into
Conversation
…SV block boundary
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
With newlines_in_values=true, a \r\n inside a quoted field can be split across two read blocks. When \r is the last byte of one block and \n is the first byte of the next, the reader drops the \n and corrupts the field value. See #51368.
What changes are included in this PR?
CSVBufferIterator now keeps a trailing \r and adds it to the next buffer instead of dropping the following \n. This keeps CRLF together across block boundaries. A pending \r at EOF is also preserved.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.
This PR contains a "Critical Fix": it fixes (b) a bug that caused incorrect data to be produced.
Was AI used for this PR?
Yes AI was used for assistance during the development process mainly in understanding the issue.
Added regression tests for the serial, async, and streaming readers.
These particular test cases were failing before the fix. All 3 now pass with the fix.
PR code and description written by:
Reviewed before submission by: