ARTEMIS-6127 Remove JDK8/IBM related code#6536
Open
GChuf wants to merge 3 commits into
Open
Conversation
Contributor
|
lgtm. We don't support JDK 1.8 for some time already. I guess you could squash your commits though? |
Contributor
|
The code in question lists JDK 8 in the comment, but it's not applying that in practice. It is simply checking for an IBM JDK. My concern here is that if later versions of IBM JDKs (e.g. 17) have the same behavior as they did in 8 then removing this code could break them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.