ARTEMIS-6203 make MQTT resiliency soak tests more robust - #6639
Merged
Conversation
There is a race in the soak tests which focus on resiliency for MQTT subscribers. There is a small window in between when the subscriber receives the initial PUBLISH packet (and records the receipt of the message) and when the broker receives the PUBREC and acknowledges the message. It's possible that the test will attempt to verify that the message is acknowledged during this window and fail. The fix is simply to use Wait to verify the acknowledgement.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race in the soak tests which focus on resiliency for MQTT subscribers. There is a small window in between when the subscriber receives the initial PUBLISH packet (and records the receipt of the message) and when the broker receives the PUBREC and acknowledges the message. It's possible that the test will attempt to verify that the message is acknowledged during this window and fail.
The fix is simply to use Wait to verify the acknowledgement.