ARTEMIS-6207 fix race condition in test - #6644
Merged
Merged
Conversation
Contributor
|
can you state which test it's fixing? isn't this a real fix? like fix race in "XYZ". This is fixing test "TestName" I would state that on the commit message. |
All the tests in o.a.a.a.c.c.i.ActiveMQServerStartupTest have a race condition where o.a.a.a.c.s.i.ActiveMQServerImpl#getCriticalAnalyzer becomes non-null before any actions are added so that when o.a.a.a.u.c.CriticalAnalyzerAccessor#fireActions is called on the next line it might not actually do anything. The fix is to wait until actions are added before assigning o.a.a.a.c.s.i.ActiveMQServerImpl#analyzer a value.
Contributor
Author
|
I fleshed out the commit message with the details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #6638.