ci: Add Fedora 44, remove other Fedora images - #2179
Merged
Conversation
jjardon
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow,
gtristan and
juergbi
as code owners
August 20, 2026 22:19
jjardon
marked this pull request as draft
August 20, 2026 22:19
jjardon
marked this pull request as ready for review
August 21, 2026 14:18
jjardon
force-pushed
the
jjardon/f44
branch
2 times, most recently
from
August 22, 2026 20:57
59a7551 to
85b4ae6
Compare
jjardon
marked this pull request as draft
August 22, 2026 21:03
jjardon
force-pushed
the
jjardon/f44
branch
2 times, most recently
from
August 22, 2026 22:32
3a57cb8 to
451ea79
Compare
jjardon
marked this pull request as ready for review
August 22, 2026 23:01
abderrahim
reviewed
Aug 23, 2026
jjardon
force-pushed
the
jjardon/f44
branch
3 times, most recently
from
August 23, 2026 13:25
0b2c2cb to
eee9bae
Compare
abderrahim
reviewed
Aug 23, 2026
|
|
||
| x-tests-env: &tests-env | ||
| TOXENV: ${CI_TOXENV_ALL} | ||
| # Interactive tests (pexpect) need a usable TERM so pagers like less |
Contributor
There was a problem hiding this comment.
Can't we set this in the pexpect tests themselves? I'm afraid that setting this globally will affect other tests as well.
Contributor
Author
There was a problem hiding this comment.
@abderrahim ok, I have proposed another way, please check; CI has passed at https://github.com/jjardon/buildstream-1/actions/runs/32643806433?pr=1
Fedora 42 is EOL for a while, python 3.14 is already tested with F44
Interactive tests allocate a PTY via pexpect but inherit the process environment. When TERM is unset or "dumb" (common in CI containers), click.echo_via_pager does not run an interactive less; the test still sends "q" as if a pager were active, which is then read as choice "quit". This happened in the new fedora 44 image, for example Ensure a usable TERM in the build_session fixture so pager-driven tests behave like a normal interactive terminal.
juergbi
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fedora 42 is EOL for a while, python 3.14 is already tested with F44
Depends on https://gitlab.com/BuildStream/buildstream-docker-images/-/merge_requests/239
Tested succesfully at jjardon#1
Fixes #2180