CAMEL-24533: camel-weaviate - store the document text in the object properties on CREATE/UPDATE (backport to camel-4.18.x) - #25997
Merged
Conversation
…roperties on CREATE/UPDATE WeaviateEmbeddingsDataTypeTransformer set the message body to the embedding vector and only wrote the optional id into the Weaviate object properties; the embedded text (the TextSegment body) was never written under textFieldName, so the source passage was silently lost. For a RAG pipeline this means the store cannot return the text that produced a match. The Milvus sibling transformer already stores the text correctly. Write the text under textFieldName into the properties for CREATE and UPDATE_BY_ID via a shared setProperties helper, merging into any PROPERTIES header the caller already set rather than replacing it. Also correct the default-branch error message, which claimed only create and updatebyid were supported although query is handled too. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Closes apache#25900 (cherry picked from commit b4c20cb)
Croway
approved these changes
Sep 1, 2026
gnodet
approved these changes
Sep 1, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Verified straight cherry-pick backport of #25900 (CAMEL-24533) to camel-4.18.x — diff is identical to the original, which was already reviewed and approved on main. CI is green.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
Claude Code on behalf of Guillaume Nodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straight cherry-pick backport to
camel-4.18.xof CAMEL-24533 (#25900), already reviewed and merged onmain:camel-weaviate: the embeddings data-type transformer stored only the vector (and optional id) on CREATE/UPDATE and silently dropped the document text, so a RAG pipeline could not return the source passage. The text is now written under
textFieldName, merged into any existingPROPERTIESheader.Clean cherry-pick of the merged main commit (no manual conflict resolution). The affected code is present on
camel-4.18.x, and the added test compiles and passes on this branch.The related camel-huggingface backports (CAMEL-24527, CAMEL-24540) are not included here because the
camel-huggingfacemodule does not exist oncamel-4.18.x.Claude Code on behalf of oscerd