Skip to content

network: restore released NIC state when a VM re-syncs Stopped/Stopping state - #14460

Draft
Pearl1594 wants to merge 2 commits into
4.22from
ghi14177-nic-reconcile-4.22
Draft

network: restore released NIC state when a VM re-syncs Stopped/Stopping state#14460
Pearl1594 wants to merge 2 commits into
4.22from
ghi14177-nic-reconcile-4.22

tests

1bce999
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Nov 6, 2026 in 6m 4s

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1034 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doThrow". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGwznSw-ZPq3As5vjqt&open=AaGwznSw-ZPq3As5vjqt&pullRequest=14460

Check warning on line 286 in engine/orchestration/src/test/java/com/cloud/vm/VirtualMachineManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_networkMgr" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGwzndY-ZPq3As5vjqx&open=AaGwzndY-ZPq3As5vjqx&pullRequest=14460

Check warning on line 2192 in engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGnTulRhlu84NSFeCq4&open=AaGnTulRhlu84NSFeCq4&pullRequest=14460

Check warning on line 1037 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGwznSw-ZPq3As5vjqw&open=AaGwznSw-ZPq3As5vjqw&pullRequest=14460

Check warning on line 1036 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGwznSw-ZPq3As5vjqv&open=AaGwznSw-ZPq3As5vjqv&pullRequest=14460

Check failure on line 762 in server/src/test/java/com/cloud/vpc/MockNetworkManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGnTu3Rhlu84NSFeCq5&open=AaGnTu3Rhlu84NSFeCq5&pullRequest=14460

Check warning on line 1035 in engine/orchestration/src/test/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestratorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGwznSw-ZPq3As5vjqu&open=AaGwznSw-ZPq3As5vjqu&pullRequest=14460
View more details on SonarQubeCloud