Skip to content

Code style cleanups split out of #12500 - #14556

Open
DaanHoogland wants to merge 1 commit into
removeOvmLeftoversfrom
deprecatedHypervisorCleanups
Open

Code style cleanups split out of #12500#14556
DaanHoogland wants to merge 1 commit into
removeOvmLeftoversfrom
deprecatedHypervisorCleanups

code style cleanups in ApiResponseHelper, Upgrade410to420, AffinityGr…

80a4500
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 6, 2026 in 4m 39s

Quality Gate failed

Failed conditions
1.4% Coverage on New Code (required ≥ 40%)
C Maintainability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 2260 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OQ&open=AaGcm-OImtHvmxH3m8OQ&pullRequest=14556

Check warning on line 2276 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OW&open=AaGcm-OImtHvmxH3m8OW&pullRequest=14556

Check warning on line 1596 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OC&open=AaGcm-OImtHvmxH3m8OC&pullRequest=14556

Check warning on line 852 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Ov&open=AaGcm-OImtHvmxH3m8Ov&pullRequest=14556

Check warning on line 1149 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O2&open=AaGcm-OImtHvmxH3m8O2&pullRequest=14556

Check warning on line 1210 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O5&open=AaGcm-OImtHvmxH3m8O5&pullRequest=14556

Check warning on line 1612 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8PB&open=AaGcm-OImtHvmxH3m8PB&pullRequest=14556

Check warning on line 2455 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NH&open=AaGcm-OImtHvmxH3m8NH&pullRequest=14556

Check warning on line 1623 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OE&open=AaGcm-OImtHvmxH3m8OE&pullRequest=14556

Check warning on line 812 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Ou&open=AaGcm-OImtHvmxH3m8Ou&pullRequest=14556

Check warning on line 2371 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OY&open=AaGcm-OImtHvmxH3m8OY&pullRequest=14556

Check warning on line 1983 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OL&open=AaGcm-OImtHvmxH3m8OL&pullRequest=14556

Check warning on line 133 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8MM&open=AaGcm-OImtHvmxH3m8MM&pullRequest=14556

Check warning on line 2455 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Od&open=AaGcm-OImtHvmxH3m8Od&pullRequest=14556

Check warning on line 2517 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NM&open=AaGcm-OImtHvmxH3m8NM&pullRequest=14556

Check warning on line 844 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Nk&open=AaGcm-OImtHvmxH3m8Nk&pullRequest=14556

Check warning on line 1941 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8M3&open=AaGcm-OImtHvmxH3m8M3&pullRequest=14556

Check warning on line 1548 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O9&open=AaGcm-OImtHvmxH3m8O9&pullRequest=14556

Check warning on line 173 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NQ&open=AaGcm-OImtHvmxH3m8NQ&pullRequest=14556

Check warning on line 878 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Nm&open=AaGcm-OImtHvmxH3m8Nm&pullRequest=14556

Check warning on line 656 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Nh&open=AaGcm-OImtHvmxH3m8Nh&pullRequest=14556

Check warning on line 2271 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8OU&open=AaGcm-OImtHvmxH3m8OU&pullRequest=14556

Check warning on line 1267 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Move this "prepareStatement" call outside the loop. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8O6&open=AaGcm-OImtHvmxH3m8O6&pullRequest=14556

Check warning on line 353 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested try block into a separate method. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8Nb&open=AaGcm-OImtHvmxH3m8Nb&pullRequest=14556

Check warning on line 2260 in engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade410to420.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaGcm-OImtHvmxH3m8NA&open=AaGcm-OImtHvmxH3m8NA&pullRequest=14556
View more details on SonarQubeCloud