Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate client certificate signatures with the configured Root CA when
strict authentication is enabled.
Run this check before the existing revocation, validity and ownership
checks. Reject the certificate if signature verification fails or the
Root CA certificate is missing. Rejected certificates are not added to
the active certificate map.
Keep the current non-strict authentication and expired certificate
settings. Add six tests using real certificates.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Strict authentication must verify certificates against the configured CA.
Screenshots (if appropriate):
Not applicable.
How Has This Been Tested?
Tested with OpenJDK 17 and Maven 3.8.7.
All 28 tests in RootCACustomTrustManagerTest and RootCAProviderTest passed.
Required modules compiled and Checkstyle passed.
Full project build and live TLS handshake testing were not run.
How did you try to break this feature and the system with this change?
Added tests for:
Four rejection tests failed before the change and passed after it.
Rejected certificates leave the active certificate map empty.
Existing expiry, revocation and ownership tests also passed.