Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #14504
When a Kubernetes cluster uses the default compute offering, its control
and worker node offering IDs are left empty. Only explicit per-node
offerings are saved.
Save the effective offering ID for control and worker nodes when creating
the cluster. Also save it for separate etcd nodes when present. Use the
default offering if no per-node offering is supplied, and keep explicit
overrides. Existing cluster records are not changed.
To reproduce:
The IDs should contain the selected default offering instead of null.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Missing node offering IDs can affect later cluster scaling.
Screenshots (if appropriate):
Not applicable. Backend change.
How Has This Been Tested?
Tested with OpenJDK 17 and Maven 3.8.7.
All 37 tests in KubernetesClusterManagerImplTest and
KubernetesClusterScaleWorkerTest passed, including four new regression
tests. Required modules compiled and Checkstyle passed.
Full project build and live-cloud testing were not run.
How did you try to break this feature and the system with this change?
Added tests for:
The default-only and partial-override tests failed with the original
storage behavior and passed after the change. Explicit offerings are
preserved, and no etcd offering is saved when separate etcd nodes are absent.