Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check access to the UserData selected by cniconfigurationid before
creating a Kubernetes cluster.
Add @acl to the API parameter, matching other UserData parameters.
Also validate the reference in the cluster service: reject a missing
record and check caller access before cluster creation proceeds.
An omitted CNI configuration is still allowed. Existing cluster
references are not changed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
The selected UserData must be accessible to the caller.
Screenshots (if appropriate):
Not applicable. Backend change.
How Has This Been Tested?
All 33 KubernetesClusterManagerImplTest tests and 13 ParamProcessWorkerTest
tests passed. Required modules compiled and Checkstyle passed.
How did you try to break this feature and the system with this change?
Added regression tests for:
Rejected requests stop before cluster persistence or further cluster
parameter processing. Existing API parameter access-check tests also passed.