Reject non-ASCII hex characters in Conversion.hexDigitToInt - #1767
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:Conversion.hexToInt("aa", 0, 0, 0, 2)(two U+FF41 FULLWIDTH LATIN SMALL LETTER A) returns170, the same value as the ASCII"aa", andConversion.hexDigitToInt('٩')(U+0669 ARABIC-INDIC DIGIT NINE) returns9. Both should throw.Cause:hexDigitToIntreads the digit withCharacter.digit(hexChar, 16), which by its own specification recognises every Unicode decimal digit and the fullwidth Latin letters U+FF21-U+FF3A / U+FF41-U+FF5A, not only0-9a-fA-F. The sibling convertershexDigitMsb0ToInt,hexDigitToBinaryandhexDigitMsb0ToBinaryswitch over ASCII and do throw on the same chars, andCharUtils.isHexagrees with them. SincehexDigitToIntis the digit decoder behindhexToByte,hexToShort,hexToIntandhexToLong, the whole hex-string surface accepts homoglyphs, and strings that differ collapse onto one value.Fix: screen the char withCharUtils.isHexbefore converting, reusing the message the siblings already use.Character.digitoccurs once in the library, so this is the only site; ASCII input is unchanged.mvn; that'smvnon the command line by itself.