Repository navigation
MATH-1392: Allow square full-rank regression without an intercept - #337
Conversation
|
The three workflows for 6fc6ba7 are waiting for approval ( |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
============================================
+ Coverage 86.54% 87.19% +0.64%
+ Complexity 9787 91 -9696
============================================
Files 532 499 -33
Lines 35516 33514 -2002
Branches 6194 5848 -346
============================================
- Hits 30738 29222 -1516
+ Misses 3518 3169 -349
+ Partials 1260 1123 -137 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Please rebase to resolve conflicts |
Permit square full-rank OLS and GLS designs without an intercept while preserving default-intercept and underdetermined-input validation. Document that error variance remains unavailable at zero residual DOF. Generated-by: DeepSeek Generated-by: Codex
82273cc to
e406d59
Compare
|
Rebased onto current master All 60 OLS/GLS tests pass. Root AI-generated reply; Git state and validation figures were checked against the execution records. |
Fixes MATH-1392: https://issues.apache.org/jira/browse/MATH-1392
Sample-size validation always reserves a column for an intercept, including when
setNoIntercept(true)is used. A full-rank 2×2 design such asx = [[1, 2], [3, 4]],y = [5, 11]is therefore rejected before OLS or GLS can solve the uniquely determined coefficients[1, 2].Count only the design columns actually used in both the flat and matrix entry points. Keep the existing default-intercept boundary, rejection of underdetermined and empty inputs, and covariance validation. This permits coefficient estimation for a square full-rank model; it does not make error variance estimable at zero residual degrees of freedom, and the Javadoc now states that limit.
Validation on the current head
e406d597(macOS arm64, JDK 17):mvn -B clean verifypassed across all 14 modules: 3,809 test cases, 33 skips, zero final failures or errors. The project's unchanged retry configuration recovered 51 randomized cases after 97 failed attempts; this was one root build invocation. Focused cases are included in this count.73bf53b4. The changelog keeps both MATH-1678 and MATH-1392; the net PR still contains only its four intended files.git diff --checkpassed. Hosted CI for this rebased head is separate and remains to complete.AI-generated description. DeepSeek and Codex assisted with investigation, implementation, tests and review. The Git state and validation figures were checked against the execution records.