Repository navigation
test: cover a native Iceberg read of a data file that omits an optional nested field - #7359
Open
yunchipang wants to merge 1 commit into
Open
yunchipang wants to merge 1 commit into
yunchipang wants to merge 1 commit into
Conversation
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7033.
Rationale for this change
The native Iceberg scan failed with
Incorrect number of arrays for StructArray fields, expected 2 got 1when a data file omitted an optional nested field without a schema change. The iceberg-rust bump in #7028 fixed this, since iceberg-rust now matches nested fields by field id and fills in missing ones with NULLs. Nothing tested this case.What changes are included in this PR?
A test in
CometIcebergNativeSuitethat writes a data file withouts.bandl.element.y, usingwrite.spark.accept-any-schema. It then checks that the native scan matches Spark, with nested schema pruning on and off.How are these changes tested?
The new test passes on main. On the parent of #7028, it fails with the error from the issue.