Skip to content

fix: read partition source columns through PartitionExpr children #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NoahKusaba wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

fix: read partition source columns through PartitionExpr children #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1917d0
fix: read partition source columns through PartitionExpr children
NoahKusaba Oct 28, 2026
2552390
test: check that PartitionExpr equality depends on its sources
NoahKusaba Oct 29, 2026
0eae2ff
Hash PartitionExpr sources and rebuild from decoded children in tests
NoahKusaba Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ input

- **`TaskWriter`** picks one of three writers: `UnpartitionedWriter`; `FanoutWriter` (accepts unsorted input, keeps many files open); or `ClusteredWriter` (requires sorted input, which is why the sort step exists).
- **Writer limits:** only Parquet is supported. The writer honors `write.parquet.*` table properties and table encryption. It matches columns by name, because DataFusion batches carry no field IDs.
- **`PartitionExpr`** is public and retains its partition spec and table schema so that distributed engines can serialize them and rebuild the expression on workers with `try_new`. Its equality and hash are by value; don't go back to pointer equality.
- **`PartitionExpr`** is public and retains its partition spec and table schema so that distributed engines can serialize them and rebuild the expression on workers with `try_new`, passing the decoded children. Its children are the top-level columns holding each partition field's source, and it reads the batch only through them, so optimizer rules like `ProjectionPushdown` that move it onto a different input rewrite them like any other column reference. Only `project_with_partition`, which checks that its input matches the table, derives the children from the table layout (crate-private `try_new_over_table`). Its equality and hash are by value; don't go back to pointer equality.

### Errors

Expand Down
Loading