Hive: Support DISTRIBUTE BY and SORT BY in window specs#2340
Open
wugeer wants to merge 4 commits into
Open
Conversation
iffyio
reviewed
Jun 18, 2026
| /// `OVER (PARTITION BY ...)` | ||
| pub partition_by: Vec<Expr>, | ||
| /// The kind of partitioning clause used in the window specification. | ||
| pub partition_by_kind: WindowPartitionByKind, |
Contributor
There was a problem hiding this comment.
for partition and order by kind, can we instead wrap the field with the enum instead of introducing a new field? i.e.
partition_by: WindowPartitionByKind
// where
enum WindowPartitionByKind {
PartitionBy(Vec<Expr>)
DistributeBy(Vec<Expr>)
}
Contributor
Author
There was a problem hiding this comment.
This is a good idea, but the change is very disruptive. Wouldn't it be better to open a separate PR for it?
Contributor
There was a problem hiding this comment.
not sure it would make sense as a separate PR given this one, since such a PR would be undoing the changes made by this one
wugeer
force-pushed
the
fix_over_distibute_by_and_sort_by
branch
from
5047be1 to
c7fb3f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Hive-gated parsing for window specs that use DISTRIBUTE BY and SORT BY, and preserve the original clause kinds in WindowSpec display output.
fix: #2339