Add pre_visit_ident / post_visit_ident hooks to the Visitor trait#2370
Merged
Conversation
0b4bb23 to
4c77156
Compare
Contributor
Author
|
Let me know if I can make this easier to review. I have a medium sized stack of commits for Snowflake dialect improvements ready to go after this one but I don't want to overwhelm the pipeline. |
Contributor
Author
|
Hi @iffyio — would you mind kicking off the CI workflow on this PR? For context, I am working on a local Snowflake emulator in Rust and will be extending the Snowflake dialect extensively. |
4c77156 to
e8b80d1
Compare
iffyio
approved these changes
Jun 23, 2026
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @sabir-akhadov-localstack!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Visitor/VisitorMuttraits had no hook for individual identifiers:Identderived a no-opVisit, so identifiers could not be observed or rewritten during a traversal. This makes it impossible to, e.g., collect every identifier in a statement or rewrite identifiers in place.This adds
pre_visit_ident/post_visit_ident(default no-op) to bothVisitorandVisitorMut, and givesIdenta manualVisit/VisitMutimpl that invokes them.Example — collect identifiers:
Tests added in
src/ast/visitor.rsfor both the immutable and mutable hooks.