Check in Cargo.lock - #2482
Open
alamb wants to merge 2 commits into
Open
Conversation
alamb
changed the title
alamb
marked this pull request as ready for review
September 7, 2026 10:45
LucaCappelletti94
suggested changes
Sep 8, 2026
LucaCappelletti94
left a comment
LucaCappelletti94
left a comment
Contributor
There was a problem hiding this comment.
To make dependency updates reliably visible in review, maybe we should use --locked in the CI? The sqlparser_bench job uses an independent manifest, so it likely needs its own committed lockfile, or possibly better a workspace integration.
| @@ -0,0 +1,412 @@ | |||
| # This file is automatically @generated by Cargo. | |||
| # It is not intended for manual editing. | |||
| version = 4 | |||
Contributor
There was a problem hiding this comment.
At this time https://github.com/apache/datafusion-sqlparser-rs/blob/main/.tool-versions still specifies Rust 1.75, and version = 4 is only supported from 1.78. I suspect that the current CI misses this because it tests only stable, beta, and nightly, and not specifically 1.75.
I am not sure whether here we would want to either bump .tool-versions or downgrade the version of the Cargo.lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Checking in
Cargo.lockgives CI reproducible builds and makes dependency updates visible in review, per the current Cargo guidance which now recommends committing the lockfile for libraries as well.What changes are included in this PR?
Cargo.lockfrom.gitignoreCargo.lockgenerated withcargo update(all 46 packages locked to the latest semver-compatible versions; noCargo.tomlchanges needed)Are these changes tested?
cargo test --all-featurespasses (22/22 suites, 0 failures).Are there any user-facing changes?
No. This only affects local development and CI of this repository; downstream users of the published crate are unaffected.