Snowflake: parse nested COPY transformation paths - #2518
Open
osipovartem wants to merge 1 commit into
Open
osipovartem wants to merge 1 commit into
osipovartem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes no issue.
Rationale for this change
Snowflake permits nested semi-structured paths in staged COPY transformations, for example
$1:country:name::VARCHAR. The dedicated simple staged-field parser currently consumes$1:countryand leaves:name::VARCHARbehind, so the documented statement fails to parse.Documentation: https://docs.snowflake.com/en/user-guide/tutorials/script-data-load-transform-parquet
What changes are included in this PR?
Simple staged fields keep their compact
StageLoadSelectItemAST; only complex expressions use the existingJsonAccess/CastAST.Are there any user-facing changes?
Yes. Snowflake COPY statements with nested staged paths now parse and round-trip correctly.
How was this change tested?
cargo test --test sqlparser_snowflake(164 passed)cargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --check