refactor(hash-aggr): Let partial-reduce mode aggregation early emit when OOM - #24785
Open
2010YOUY01 wants to merge 2 commits into
Open
refactor(hash-aggr): Let partial-reduce mode aggregation early emit when OOM#247852010YOUY01 wants to merge 2 commits into
2010YOUY01 wants to merge 2 commits into
Conversation
…ial-reduce mode aggregation OOM
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24785 +/- ##
==========================================
+ Coverage 81.24% 81.52% +0.28%
==========================================
Files 1113 1123 +10
Lines 392744 406130 +13386
Branches 392744 406130 +13386
==========================================
+ Hits 319090 331115 +12025
- Misses 54900 55649 +749
- Partials 18754 19366 +612 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #22710
Rationale for this change
See #24486 for the rationale. That discussion covers the issue and three potential solutions: error, early-emit, and spill.
This PR implements the early-emit behavior agreed on there.
What changes are included in this PR?
Key changes:
In datafusion/physical-plan/src/aggregates/partial_reduce_stream.rs
poll_next()and follow alongAre these changes tested?
UTs (note partial-reduce aggregation can't be planned from SQL, so we can't do sqllogictests here)
Are there any user-facing changes?
No